Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build script for Rust based Wasm benchmarks #1111

Merged
merged 6 commits into from
Jul 6, 2024

Conversation

Robbepop
Copy link
Member

@Robbepop Robbepop commented Jul 6, 2024

This adds a simple build script to automatically build all Rust sourced Wasm benchmarks.
Also this moves the generated Wasm files into their respective source directories as out.wasm.

This big advantage is that this heavily simplifies building the Wasm benchmarks and avoids having developers to install tools such as wasm-opt manually on their machines.
Also this tool automatically detects all Rust sourced Wasm benchmarks and automatically builds when when invoked.

Example run:

> cargo run --package build_benches             
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.09s
     Running `target/debug/build_benches`
tiny_keccak:
    building .. done
    optimizing .. done
    finalizing .. done
reverse_complement:
    building .. done
    optimizing .. done
    finalizing .. done
regex_redux:
    building .. done
    optimizing .. done
    finalizing .. done

Copy link

codecov bot commented Jul 6, 2024

Codecov Report

Attention: Patch coverage is 2.77778% with 35 lines in your changes missing coverage. Please review.

Project coverage is 80.00%. Comparing base (9b298c1) to head (be0bb13).

Files Patch % Lines
crates/wasmi/benches/rust/build/main.rs 2.77% 35 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1111      +/-   ##
==========================================
- Coverage   80.11%   80.00%   -0.12%     
==========================================
  Files         274      275       +1     
  Lines       25195    25231      +36     
==========================================
+ Hits        20184    20185       +1     
- Misses       5011     5046      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Robbepop Robbepop merged commit e316baa into main Jul 6, 2024
16 of 18 checks passed
@Robbepop Robbepop deleted the rf-add-bench-build-script branch July 6, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant